Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pf5): upgrade TargetContextSelector #1304

Merged
merged 23 commits into from
Jul 25, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jul 25, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #1110
See #1303

Description of the change:

  1. Fixes up functionality so targets can be selected
  2. Uses the item "description" field to display the connect URL, instead of placing it in parentheses
  3. Adds a "Clear selection" button, related to [Task] Handle "no target" selection on Dashboard #883

Notes

Card resize functionality on the dashboard is broken, so visiting the dashboard with a selected target breaks the UI. Go directly to /recordings via URL to sidestep this issue. You can "Clear selection" before going back to the Dashboard, if necessary.
Turns out this was a one-liner fix, so I included it here.

@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. safe-to-test labels Jul 25, 2024
@mergify mergify bot mentioned this pull request Jul 25, 2024
7 tasks
@andrewazores andrewazores marked this pull request as ready for review July 25, 2024 19:10
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceee! Looks good to me!

@aali309
Copy link
Contributor

aali309 commented Jul 25, 2024

Awesome, looks good.

@andrewazores andrewazores merged commit 7df9632 into cryostatio:pf5 Jul 25, 2024
8 checks passed
@andrewazores andrewazores deleted the target-selector branch July 25, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants